Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: GraphQL support for Frappe #11339

Closed
wants to merge 1 commit into from

Conversation

pipech
Copy link
Contributor

@pipech pipech commented Aug 23, 2020

Adding GraphQL support for Frappe

Adding GraphQL to Frappe using Graphene GraphQL libary in Python

Since GraphQL is strong typing, we won't try to add some check box to DocType to enable GraphQL , instead we will aim to create object such as FrappeObjectType to fetch frappe doctype and convert to Graphene object.

Developer will have to create manually create FrappeObjectType to enable GraphQL for each Doctype.

Schema should be create at server start (or some sort), it should fetch all Graphene object from each installed apps and then add it to Root schema.

Todo list

@pipech pipech changed the title WIP: GraphQL for Frappe [WIP] feat: GraphQL support for Frappe Aug 23, 2020
@ahmadRagheb
Copy link
Contributor

i have spend each weekend working on same goal for the last couple weeks , i will be happy to contribute.

@ahmadRagheb
Copy link
Contributor

https://github.com/ahmadRagheb/graphene_frappe
i have add page in www for providing a ui

@rmehta
Copy link
Member

rmehta commented Aug 24, 2020

  • Please use tabs instead of spaces as per the standards for Frappe
  • Tests will be absolutely necessary

@rmehta rmehta marked this pull request as draft August 24, 2020 04:10
@surajshetty3416
Copy link
Member

Also @pipech, please raise PR for develop branch. We do not accept pull requests directly on version-12 branch.

https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist#which-branch

@pipech
Copy link
Contributor Author

pipech commented Aug 24, 2020

@surajshetty3416 Could you keep it open just for now, since I'm planing to use it on version 12 and will develop on version 12.
After I'm finished developing I'll close this pull request and re-open it on version 13.

@ncaspari
Copy link

@pipech and are you still working on this? Does the code fully work, or did you run into any issues that made you think that this implementation is not as easy as expected?

@ncaspari
Copy link

@rmehta @surajshetty3416 do you know of any other projects that are working on a GraphQL implementation at the moment?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants