[fix] Don't overwrite docfield properties while rendering, if it's modifed on refresh event #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't the correct fix |
anandpdoshi
added a commit
to anandpdoshi/frappe
that referenced
this pull request
Jun 18, 2015
…gering refresh event via script manager. Fixes frappe#1158
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to fix dynamic label issue, which we set in all transactions for total fields based on currency. Label are changed on "refresh" event, after that when system renders form, docfield obj is reloading based on meta, which resets label.
@rmehta / @anandpdoshi Is this right fix? I am not sure about this, though I tested and it is working.