Mysql/Aurora support for Frappe

[seethersan]

Please provide enough information so that others can review your pull request:
Gives Frappe compatibility with Aurora/Mysql database by setting the db_type option in the site's site_config.json file as follows:

 ...
 "db_type": "mysql"
...

You can also add it in the new-site command

bench new-site --db-type mysql site1.local

Explain the details for making this change. What existing problem does the pull request solve?
This change allows the use of ERPNext with AWS Aurora/Mysql.

Screenshots/GIFs

[rmehta]

how is this different from MariaDB?

Would it be better to subclass mariadb/database.py for fixes?

[seethersan]

The difference is the use of COMPRESS format in table creation because it isn't compatible with Aurora/Mysql. The main reason I used this approach is to allow the use of this solution as an option in db_type inside site_config file.

[bitgandtter]

It feels less disruptive at been an opt-in feature

[rmehta]

@seethersan closing this since this has significant code repetition. The subclass must only update the methods that change. Please reopen after fixing.

[bitgandtter]

Is there any intention of allow usage of other database like MySQL 8 or aurora?

[rmehta]

Yeah, if there is someone who is ready to support it.

…

On 17-Nov-2020, at 7:05 PM, Yasmany Cubela Medina ***@***.***> wrote: Is there any intention of allow usage of other database like MySQL 8 or aurora? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#11812 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABCGLDSRQZSJK2Y7YNJRWTSQJ33JANCNFSM4TCUTEXA>.

[bitgandtter]

We are in need to be able to switch to mysql8 or aurora, we need managed databases and sadly not all managed database providers have mariadb on their stock. If you or anyone let us know what we can do to help move on that direction we will happy do it

[rmehta]

@bitgandtter make sure you follow contribution guidelines correctly or find someone who can do this the right way. I can recommend @revant ?

[revant]

Search the frappe/erpnext code base for "mariadb" or 'mariadb', there are many places where it is used.
Also in many places frappe.db.multisql() is used. What's the plan regarding that?

@bitgandtter to use Aurora refer this https://discuss.erpnext.com/t/erpnext-installation-in-rds-aurora-mysql/48596/6

[nikoma]

I see that this is 2 years old. Has this been integrated at some point? We are planning a large rollout and would love to use Amazon Aurora.