Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create auto_repeat field only if docfield/custom field does not exist #11827

Merged

Conversation

ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented Oct 30, 2020

Some Standard DocTypes already have an auto_repeat standard field. Checking Allow Auto Repeat breaks here, since it tries to create a custom field when a standard docfield already exists.

photo_2020-10-30 14 07 18

Fix: Create custom field only if standard docfield / custom field is not already present. This property is now enabled for such doctypes in frappe/erpnext#23776

@ghost ghost removed their request for review October 30, 2020 08:43
@surajshetty3416
Copy link
Member

@ruchamahabal can we move create_auto_repeat_custom_field_if_required outside fetch_to_customize because create_auto_repeat_custom_field_if_required is getting called unnecessarily on customize form load.

We can move it to save_customization.

@scmmishra scmmishra merged commit 563761c into frappe:develop Nov 18, 2020
@scmmishra
Copy link
Contributor

@Mergifyio backport version-13-beta

@mergify
Copy link
Contributor

mergify bot commented Nov 18, 2020

Command backport version-13-beta: success

Backports have been created

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants