Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use html.unescape for Python 3.9 compatibility. #12005

Merged
merged 1 commit into from Nov 27, 2020
Merged

fix: Use html.unescape for Python 3.9 compatibility. #12005

merged 1 commit into from Nov 27, 2020

Conversation

tirkarthi
Copy link
Contributor

@tirkarthi tirkarthi commented Nov 26, 2020 •
edited by gavindsouza

Please provide enough information so that others can review your pull request:

HTMLParser.unescape has been deprecated and removed in favor of html.unescape (Added in PY3.4 #ref) in Python 3.9

Explain the details for making this change. What existing problem does the pull request solve?

This PR adds Python 3.9 compatibility

@tirkarthi tirkarthi requested a review from a team as a code owner November 26, 2020 13:32
@tirkarthi tirkarthi requested review from scmmishra and removed request for a team November 26, 2020 13:32
@gavindsouza gavindsouza self-assigned this Nov 27, 2020
@mergify mergify bot merged commit 241ce34 into frappe:develop Nov 27, 2020
@gavindsouza gavindsouza mentioned this pull request Nov 27, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gavindsouza gavindsouza gavindsouza approved these changes

@scmmishra scmmishra Awaiting requested review from scmmishra

Assignees

@gavindsouza gavindsouza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tirkarthi @gavindsouza