Fix SysManager Perms #1207
Closed
Fix SysManager Perms #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the system manager only can Read the Module Def, this is a violation of the rule https://github.com/frappe/frappe/blob/develop/frappe/installer.py#L114, that only enable the app installation by the System Manager, but if the app needs create module defs, the modules aren't created and the install crash.
|
Can't we just add https://github.com/frappe/frappe/blob/develop/frappe/installer.py#L230 |
rmehta
added a commit
that referenced
this pull request
Aug 10, 2015
|
Fixed in my branch (release next week) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the system manager only can Read the Module Def, this is a violation of the rule https://github.com/frappe/frappe/blob/develop/frappe/installer.py#L114, that only enable the app installation by the System Manager, but if the app needs create module defs, the modules aren't created and the install crash.