Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to set default desk page #12214

Merged
merged 5 commits into from Feb 1, 2021

Conversation

nextchamp-saqib
Copy link
Member

@nextchamp-saqib nextchamp-saqib commented Jan 14, 2021

Currently, if user has to display customisations across users, he has to edit the Standard Desk Pages for eg. Accounting Page in ERPNext.

Now for standard pages, the changes are stored in JSON rather than database, on migrate or new releases these customisations on standard pages gets reset since JSON is reset.

The above problem can be rectified by creating a new Desk Page extending the standard one, but this won't replace the standard one, but it will be shown beside it.

This PR introduces a check called 'Is Default' which can be checked if a desk page is extended from another, this check behaves same as, user-defined customised page but it is for all users.
i.e a Custom Accounting Page extending standard Accounting with Is Default checked will be shown to all users.


To customise a standard page:

  • Duplicate the standard one
  • Uncheck Is Standard, Check Extends Another Page, Check Is Default
  • In Extends field select the Standard Page
  • Customise the page by removing or adding stuffs.
  • Save the document

Now reload the desk and check if the standard page shows the above customised version.

Docs: frappe/erpnext_documentation#244

@nextchamp-saqib nextchamp-saqib requested a review from a team as a code owner January 14, 2021 12:56
@nextchamp-saqib nextchamp-saqib requested review from prssanna and removed request for a team January 14, 2021 12:56
Co-authored-by: Prssanna Desai <prssud@gmail.com>
@Olawale1
Copy link

Olawale1 commented Jan 22, 2021

Great! I was just going to post this issue... glad to see there's a PR already. Will the user also be able to set Custom Desk Pages as Default?

Kind regards,

@Olawale1
Copy link

Olawale1 commented Feb 5, 2021

Just for clarity, I'm referring to custom Desk Pages that are not extending a Standard one. The system manager should still be able to set such Desk Pages as default for all users

Thanks

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants