fix: Webform checkout #12756
Merged
fix: Webform checkout #12756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajshetty3416
requested changes
Apr 2, 2021
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
…08/frappe into fix-payment-in-webform
surajshetty3416
approved these changes
Apr 8, 2021
|
@surajshetty3416, with the change in get_payment_gateway_url method in web_form file, the on_payment_authorized method defined in any doctype for which the payment is made isn't getting triggered. The reference doctype and docname is getting triggered as "Web Form" and the name of the web form respectively. Kindly let us know if there is any alternative method for this ? |
harshpwctech
added a commit
to harshpwctech/frappe
that referenced
this pull request
Dec 23, 2021
This change is proposed as on_payment_authorized method defined in any doctype for which the payment is made isn't getting triggered. frappe#12756
mergify bot
pushed a commit
that referenced
this pull request
Jan 6, 2022
This change is proposed as on_payment_authorized method defined in any doctype for which the payment is made isn't getting triggered. #12756
conncampbell
pushed a commit
to conncampbell/frappe
that referenced
this pull request
Jan 9, 2022
This change is proposed as on_payment_authorized method defined in any doctype for which the payment is made isn't getting triggered. frappe#12756
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We store the payment gateway details in Webform but we are passing the reference doctype.
The reference doctype does not have the gateway stuff so this error is thrown
To test please use the keys here
Steps to reproduce test
4242 4242 4242 4242valid expiry and any test cvvfor other reference implementation check payment request in erpnext