New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Show language switcher for guest users on navbar #12813
feat: Show language switcher for guest users on navbar #12813
Conversation
surajshetty3416
commented
Apr 7, 2021
•
edited
edited
- Language toggle option for guest users
- The server will decide the user's language preference using the "preferred_language" cookie
- Selected language will be remembered via "preferred_language" cookie stored in browser
7e36b0f
to
f72871e
Compare
f72871e
to
df0578d
Compare
|
How will this work? From where will the user be able to switch the language?
Yep, was worried about the cookie getting cleared after someone logs in. But it works because we are not clearing |
Before user enters their preference for the first time, we can take a good guess using this. |
526f4f5
to
b41c5b5
Compare
@surajshetty3416 is there any way to limit the languages shown? For example, I would like my website to be available in English and Russian only. I will take care to translate all the labels in these languages. The user experience would be very poor when selecting German as a language. |
Yes, we have discussed this internally... @rohitwaghchaure is/will be working on this & other enhancements. |
You can now disable Language document and it won't show up on the selector. |