Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: New Feedback & Comment Design for Blog Post #14614

Merged
merged 8 commits into from Nov 16, 2021

Conversation

shariquerik
Copy link
Member

@shariquerik shariquerik commented Oct 28, 2021

  • Remove Rating & Feedback from Blog Post and replace it with Like❤️.
  • New Blog Post Comment Design (Similar to form comment design).
  • Add a Rate limiting feature on Blog Post Comment.
  • Add Feedback limit & Comment Limit per hour on Blog Settings Doctype.
  • Add Allow guest to comment check on Blog Settings Doctype.

Before:
Collapsed Comment & Feedback:
image

Opened Comment & Feedback:
image

After:
image

For logged in user:
image

For guest user:
image

Blog Settings Doctype:
image

@shariquerik shariquerik marked this pull request as draft October 28, 2021 15:36
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #14614 (ed28022) into develop (1e33f38) will decrease coverage by 0.07%.
The diff coverage is 91.30%.

@@             Coverage Diff             @@
##           develop   #14614      +/-   ##
===========================================
- Coverage    53.63%   53.56%   -0.08%     
===========================================
  Files          743      743              
  Lines        64740    64737       -3     
  Branches      5385     5385              
===========================================
- Hits         34724    34677      -47     
- Misses       26719    26771      +52     
+ Partials      3297     3289       -8     
Flag Coverage Δ
server 57.25% <91.30%> (-0.07%) ⬇️
ui-tests 46.67% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@shariquerik shariquerik removed the request for review from a team November 1, 2021 15:22
Copy link
Member

@surajshetty3416 surajshetty3416 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shariquerik since we do not have a shadow for avatar in the form timeline... let's remove it from here as well.

Let's keep the design as consistent as possible with our existing components.

@shariquerik shariquerik marked this pull request as ready for review November 10, 2021 15:39
@shariquerik
Copy link
Member Author

Unrelated patches and tests are failing.

@rmehta rmehta merged commit f4eff6f into frappe:develop Nov 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants