refactor: Misc changes in commands #15060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #15060 +/- ##
===========================================
- Coverage 50.50% 50.45% -0.05%
===========================================
Files 736 736
Lines 64337 64337
Branches 5301 5301
===========================================
- Hits 32491 32463 -28
- Misses 28040 28068 +28
Partials 3806 3806
Flags with carried forward coverage won't be shown. Click here to find out more. |
* Manage colours through click * Standardize the command's behaviour for consistency :') * Use click instead of webbrowser module * Simplify logic
* Add type hints for Command test suite * Remove support utils - dead code
gavindsouza
force-pushed
the
refactor-commands
branch
from
cd41a98
to
0657524
Compare
gavindsouza
requested review from
a team and
hasnain2808
and removed request for
a team
surajshetty3416
approved these changes
Nov 26, 2021
gavindsouza
added a commit
to gavindsouza/bench
that referenced
this pull request
Nov 26, 2021
This patch runs only if Frappe >= v14. Doesn't do anything else Frappe PR: frappe/frappe#15060
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
archived_sitestoarchived/sites- This is for consistency in terms of maintaining a common folder for everything archived:./archived/apps,./archived/sites,./archived/envs(so far) [ref: https://github.com/feat: get-app on steroids bench#1208]I also plan on writing a patch in bench to move all contents of
archived_sitesintoarchived/sitesand makingarchived_sitesa symbolic link that points toarchived/sites