fix: Added regex for alerts #15833
Merged
fix: Added regex for alerts #15833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadrak98
requested review from
surajshetty3416
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## develop #15833 +/- ##
===========================================
- Coverage 53.57% 53.53% -0.04%
===========================================
Files 754 754
Lines 66440 67558 +1118
Branches 5622 6090 +468
===========================================
+ Hits 35593 36166 +573
- Misses 27428 27810 +382
- Partials 3419 3582 +163
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
surajshetty3416
approved these changes
Feb 14, 2022
surajshetty3416
changed the title
|
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added regex for popups such as alert, prompt and confirm on client side.
Previously only script tags were identified which left many pyloads bypass even after apply sanitization.
Also, rearranged the strategies to check for payloads since if both strategies are applicable then html escape makes the script tag unidentifiable
.