Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Thumbnail for external images (from URL) [v13] #15838

Merged
merged 7 commits into from Feb 7, 2022
Merged

fix: Thumbnail for external images (from URL) [v13] #15838

merged 7 commits into from Feb 7, 2022

Conversation

gavindsouza
Copy link
Collaborator

@gavindsouza gavindsouza commented Feb 2, 2022 •
edited

Changes

  • Generate thumbnail for external images
  • Handle thumbnail generation for image URIs without extensions
  • Handle serving for binary files under static assets

v13 Port of #15661

@gavindsouza gavindsouza added the tests-failing Automated tests are failing. Please resolve if it is due to the changes in current PR. label Feb 2, 2022
@gavindsouza gavindsouza changed the title fix: Thumbnail for external images (from URL) fix: Thumbnail for external images (from URL) [v13] Feb 2, 2022
@gavindsouza gavindsouza requested a review from a team as a code owner February 7, 2022 08:02
@gavindsouza gavindsouza removed the tests-failing Automated tests are failing. Please resolve if it is due to the changes in current PR. label Feb 7, 2022
@gavindsouza
Copy link
Collaborator Author

@Mergifyio backport version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Feb 7, 2022

backport version-13-pre-release

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@mergify mergify bot merged commit aeeba27 into version-13-hotfix Feb 7, 2022
@mergify mergify bot mentioned this pull request Feb 7, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Feb 7, 2022

backport version-13-pre-release

✅ Backports have been created

gavindsouza added a commit that referenced this pull request Feb 7, 2022
@gavindsouza
Merge pull request #15896 from frappe/mergify/bp/version-13-pre-relea…
b24ae35 
…se/pr-15838

fix: Thumbnail for external images (from URL) [v13] (backport #15838)
@rohitwaghchaure rohitwaghchaure mentioned this pull request Feb 9, 2022
Merged
@gavindsouza gavindsouza mentioned this pull request Feb 10, 2022
Merged
@rohitwaghchaure rohitwaghchaure mentioned this pull request Feb 21, 2022
Merged
@adityahase adityahase deleted the thumbnail-for-images-v13 branch May 28, 2022 12:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@surajshetty3416 surajshetty3416 surajshetty3416 approved these changes

Assignees

@surajshetty3416 surajshetty3416

Labels
frappe-support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gavindsouza @surajshetty3416