-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: make automatically following documents optional #16030
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #16030 +/- ##
===========================================
- Coverage 56.80% 55.25% -1.56%
===========================================
Files 758 756 -2
Lines 67423 67261 -162
Branches 5797 5770 -27
===========================================
- Hits 38297 37162 -1135
- Misses 25576 26275 +699
- Partials 3550 3824 +274
Flags with carried forward coverage won't be shown. Click here to find out more. |
4faa1bf
to
a2db9a5
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
06bd63f
to
c94ebd8
Compare
Test Failures caused by: #15964 |
Added by mistake in frappe#16030
Creating content for Document Follow emails is very heavy.
It collects all changes and comments for each document followed by a user
Changes:
Minor optimizations on how the users and changes are collected
Limiting document per user to 50. Ordered by the latest document followed. This will make the job execution time to depend only on the number of users and the number of documents they are following
Typical Document Follow Email for reference
Docs for Document Follow: https://docs.erpnext.com/docs/v13/user/manual/en/setting-up/email/document-follow