Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove payment gateways (and related things) #16224

Merged
merged 22 commits into from
Jul 27, 2022

Conversation

phot0n
Copy link
Contributor

@phot0n phot0n commented Mar 9, 2022

This pr aims to remove payment gateways from frappe and move it to a separate app.

TODO:

@stale
Copy link

stale bot commented Mar 18, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Mar 18, 2022
@stale stale bot closed this Mar 21, 2022
@phot0n phot0n reopened this Mar 21, 2022
@stale stale bot removed the inactive label Mar 21, 2022
@phot0n phot0n force-pushed the remove-payment-gateways branch 3 times, most recently from a8b825f to c3b17cf Compare March 24, 2022 05:58
@stale
Copy link

stale bot commented Apr 5, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added inactive and removed inactive labels Apr 5, 2022
@phot0n phot0n force-pushed the remove-payment-gateways branch 5 times, most recently from 7f2c881 to ab9c6e2 Compare April 6, 2022 18:34
@stale stale bot added the inactive label Apr 13, 2022
@frappe frappe deleted a comment from stale bot Apr 14, 2022
@stale stale bot removed the inactive label Apr 14, 2022
@stale stale bot added the inactive label Apr 25, 2022
@frappe frappe deleted a comment from stale bot Apr 25, 2022
@stale stale bot removed the inactive label Apr 25, 2022
@stale
Copy link

stale bot commented May 2, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label May 2, 2022
@stale stale bot closed this May 5, 2022
@phot0n phot0n reopened this Jul 22, 2022
@phot0n phot0n removed the inactive label Jul 22, 2022
@phot0n phot0n force-pushed the remove-payment-gateways branch 2 times, most recently from 72ef768 to d345097 Compare July 26, 2022 17:43
@phot0n phot0n marked this pull request as ready for review July 27, 2022 05:32
@phot0n phot0n requested a review from a team July 27, 2022 05:32
@surajshetty3416 surajshetty3416 merged commit d66333d into frappe:develop Jul 27, 2022
@phot0n phot0n deleted the remove-payment-gateways branch July 27, 2022 09:31
@surajshetty3416
Copy link
Member

surajshetty3416 commented Jul 28, 2022

@phot0n please update migration guide. Migration guide should mention that payments related code was moved to a separate app with app link.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants