Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Remove dead functionality #16450

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Conversation

gavindsouza
Copy link
Collaborator

@gavindsouza gavindsouza commented Mar 30, 2022

Following features have been removed from Core since they don't add any value to the system, are unmaintained, partially developed and undocumented.

  • K.I.S.S. bot
  • frappe.utils.reset_doc

The feature has been removed from Core since it doesn't add any value to
the system, is unmaintained, partially developed and undocumented.
@gavindsouza gavindsouza requested a review from a team March 30, 2022 06:04
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #16450 (9819cde) into develop (541d8e6) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #16450      +/-   ##
===========================================
+ Coverage    53.85%   54.05%   +0.20%     
===========================================
  Files          746      743       -3     
  Lines        66489    66133     -356     
  Branches      5561     5556       -5     
===========================================
- Hits         35808    35749      -59     
+ Misses       26827    26511     -316     
- Partials      3854     3873      +19     
Flag Coverage Δ
server 61.82% <100.00%> (+0.27%) ⬆️
ui-tests 39.62% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Removed because it's a long forgotten, unused module that seems to be straight up
broken
@gavindsouza gavindsouza changed the title fix!: Remove "K.I.S.S. Bot" functionality fix!: Remove dead functionality Mar 30, 2022
@gavindsouza gavindsouza merged commit e6e9370 into frappe:develop Mar 30, 2022
@gavindsouza
Copy link
Collaborator Author

Ignored unrelated flaky Cypress test

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant