feat(minor)!: Add document reference to Error Log and doc.log_error #16653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmehta
requested review from
gavindsouza,
surajshetty3416 and
ruchamahabal
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #16653 +/- ##
===========================================
- Coverage 57.37% 53.42% -3.95%
===========================================
Files 762 749 -13
Lines 68145 67363 -782
Branches 5890 5711 -179
===========================================
- Hits 39098 35991 -3107
- Misses 25464 27226 +1762
- Partials 3583 4146 +563
Flags with carried forward coverage won't be shown. Click here to find out more. |
rmehta
added
the
Skip Manual Testing
gavindsouza
reviewed
Apr 21, 2022
| @@ -1052,4 +1052,4 @@ def attach_files_to_document(doc, event): | |||
| folder="Home/Attachments", | |||
| ).insert() | |||
| except Exception: | |||
| frappe.log_error(title=_("Error Attaching File")) | |||
| file_doc.log_error("Error Attaching File") | |||
There was a problem hiding this comment.
Handling this exception leads to a NameError since the variable file_doc won't be defined if the insert isn't successful.
Will fix this via #16289
gavindsouza
added a commit
to gavindsouza/frappe
that referenced
this pull request
Apr 21, 2022
ankush
reviewed
May 2, 2022
| @@ -2068,25 +2068,36 @@ def logger( | |||
| ) | |||
|
|
|||
|
|
|||
| def log_error(message=None, title=_("Error")): | |||
| def log_error(title=None, message=None, reference_doctype=None, reference_name=None): | |||
There was a problem hiding this comment.
Why is this order switched? There are 100s of log_error calls who will check and fix them all? 🤦
There was a problem hiding this comment.
I agree with @ankush. It's used everywhere. Will make a lot of error handling fail. Doing this will also make the API inconsistent, since msgprint still has the msg first.
ankush
changed the title
51 tasks
This was referenced Jul 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference_doctype,reference_name) to be able to track and filter source of errordoc.log_error(title, message)