perf!: simpler frappe.get_system_setting
#16685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why this needs to be "cached" in locals again when db object already caches it in value_cache.
ankush
changed the title
frappe.get_system_setting
Codecov Report
@@ Coverage Diff @@
## develop #16685 +/- ##
===========================================
- Coverage 53.90% 52.76% -1.15%
===========================================
Files 752 752
Lines 67283 67279 -4
Branches 5736 5736
===========================================
- Hits 36269 35498 -771
- Misses 26945 27712 +767
Partials 4069 4069
Flags with carried forward coverage won't be shown. Click here to find out more. |
gavindsouza
approved these changes
Apr 20, 2022
51 tasks
This was referenced Jul 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this needs to be "cached" in locals again when db object already caches it in value_cache.
Breaking Change: Got rid of local
frappe.local.system_settings, which doesn't seem to be used by anywhere. Accessing this directly is dangerous anyway since it depends on whetherget_system_settingswas called with required key or not.