Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Remove wrapt package #16715

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Conversation

ChillarAnand
Copy link
Contributor

@ChillarAnand ChillarAnand commented Apr 22, 2022

Removing wrapt as it is an overhead for a single use case.

Refs #16710

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #16715 (f36a748) into develop (7d9695a) will increase coverage by 5.70%.
The diff coverage is 62.50%.

❗ Current head f36a748 differs from pull request most recent head a9492ba. Consider uploading reports for the commit a9492ba to get more accurate results

@@             Coverage Diff             @@
##           develop   #16715      +/-   ##
===========================================
+ Coverage    52.19%   57.89%   +5.70%     
===========================================
  Files          746      762      +16     
  Lines        67102    68216    +1114     
  Branches      5707     5912     +205     
===========================================
+ Hits         35022    39496    +4474     
+ Misses       27994    25138    -2856     
+ Partials      4086     3582     -504     
Flag Coverage Δ
server 63.49% <70.32%> (+2.44%) ⬆️
ui-tests 48.17% <43.24%> (+12.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ChillarAnand ChillarAnand marked this pull request as ready for review April 22, 2022 12:29
@ChillarAnand ChillarAnand requested a review from a team April 22, 2022 12:29
@ChillarAnand ChillarAnand added the Skip Manual Testing The changes in this PR does not require manual testing. label Apr 26, 2022
@ankush ankush removed the Skip Manual Testing The changes in this PR does not require manual testing. label Apr 26, 2022
frappe/__init__.py Outdated Show resolved Hide resolved
@gavindsouza gavindsouza changed the title refactor: Remove wrapt package refactor!: Remove wrapt package Apr 26, 2022
@gavindsouza gavindsouza self-assigned this Apr 26, 2022
Also replaced inspect.getfullargspec with inspect.signature to
preserve signature of a decorated functions.
@gavindsouza gavindsouza merged commit f4394f1 into frappe:develop Apr 27, 2022
@shariquerik
Copy link
Member

@ChillarAnand #17225
I think this PR is causing the issue, can you check

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants