feat!: Added support for IS in frappe qb #16877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rmmr for the fix! |
gavindsouza
added
the
add-test-cases
Codecov Report
@@ Coverage Diff @@
## develop #16877 +/- ##
===========================================
- Coverage 57.95% 56.24% -1.72%
===========================================
Files 764 765 +1
Lines 68630 68632 +2
Branches 5950 5950
===========================================
- Hits 39775 38602 -1173
- Misses 25229 26404 +1175
Partials 3626 3626
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
:) |
phot0n
reviewed
May 11, 2022
Ported from dickerschutz@53148c3 Co-authored-by: Raymond Reggers <me@rmmr.dev>
gavindsouza
added
squash
and removed
add-test-cases
|
Realized this is a breaking change. Although, I like having this for the sake of predictability and "correctness". Here's what the query looked like in v12:
Here's what the query looked like in v13:
|
gavindsouza
requested changes
May 12, 2022
gavindsouza
changed the title
phot0n
reviewed
May 12, 2022
gavindsouza
approved these changes
May 18, 2022
51 tasks
This was referenced Jul 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16869
Using dickerschutz@53148c3