fix!: dont delete customizations when doctypes are deleted #17009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
force-pushed
the
delete_doctype_changes
branch
from
b5b2dda
to
3ce621e
Compare
Codecov Report
@@ Coverage Diff @@
## develop #17009 +/- ##
===========================================
- Coverage 58.36% 56.66% -1.71%
===========================================
Files 770 770
Lines 68879 68883 +4
Branches 6005 6005
===========================================
- Hits 40200 39030 -1170
- Misses 25070 26244 +1174
Partials 3609 3609
Flags with carried forward coverage won't be shown. Click here to find out more. |
ankush
force-pushed
the
delete_doctype_changes
branch
from
3ce621e
to
d55ac28
Compare
If someone deletes doctype and restores it back all customization are lost, there's no "real" reason to delete all these customization. They are only ever active if the doctype is being used. Explanations: - Custom field: is used by meta when doctype meta is requested, if meta isn't requested then custom field is effectively inactive. - Client script: loaded by meta when doctype is requested by desk. So inactive in deleted state. - Property setter: loaded by meta, so inactive when doctype isn't present. - Report: will break doctype isn't present, but user should delete them manually to avoid loss of "scripts" or anything special they might have done. Also report's doctype don't 100% indicate that it's based solely on that doctype.
Whole lot of unnecessary complexity, closure, multiple function calls, comprehensions all that can be replaced with single `get_all`
This is done during app install stage and causes unnecessary failures where stale doctypes are left in db.
ankush
force-pushed
the
delete_doctype_changes
branch
from
d55ac28
to
82cc983
Compare
51 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone deletes doctype and restores it back all customization are
lost, there's no "real" reason to delete all these customization. They
are only ever active if the doctype is being used.
Explanations:
isn't requested then the custom field is effectively inactive.
inactive in a deleted state.
present.
manually to avoid loss of "scripts" or anything special they might
have done. Also, report's doctype don't 100% indicate that it's based
solely on that doctype.
More unrelated fixes:
keyerrordelete_from_tableIDK any other error that occurs during routine usage with stale doctype/modules. If you find any point it out and we will handle it better 馃槄 basically: