Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(minor): Email Unsubscription [v13] #17334

Merged

Conversation

gavindsouza
Copy link
Collaborator

@gavindsouza gavindsouza commented Jun 28, 2022

v13 Ports of #17228, #17331 and #16505

netchampfaris and others added 3 commits June 28, 2022 12:52
spaces get converted to %20 which breaks text replacement
This is to avoid executing finally before the flag being set which would
change the present exception to something else.
* Add fallback label "Unsubscribe" instead of printing None in the email
* Add typing hints, f-stringify & make code DRY-er for better readability
@gavindsouza gavindsouza requested a review from a team June 28, 2022 07:31
@gavindsouza gavindsouza changed the title refactor(minor): get_unsubscribe_message [v13] refactor(minor): Email Unsubscription [v13] Jun 28, 2022
@gavindsouza gavindsouza merged commit c1970a2 into frappe:version-13-hotfix Jun 28, 2022
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 13.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants