Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: rebuild website search index in background #17974

Merged
merged 4 commits into from
Aug 26, 2022

Conversation

ankush
Copy link
Member

@ankush ankush commented Aug 26, 2022

Changes:

  1. Move website search index rebuilding to background
  2. Don't execute all enqueued jobs synchronously during migration. This was added to accommodate the lack of Redis queue availability during the update... but that's not the case now. [patch][fix] handle enqueuing while deleting document when redis is not connected #2988

refer #17949

This was added a long time ago to handle missing redis during migrate.
It is not the case right now as redis HAS to be availabe during
migration.

ref: frappe#2988
@ankush ankush requested review from a team and phot0n and removed request for a team August 26, 2022 08:04
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Aug 26, 2022
@ankush ankush removed the add-test-cases Add test case to validate fix or enhancement label Aug 26, 2022
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #17974 (9ec422e) into develop (e8af6b2) will decrease coverage by 0.02%.
The diff coverage is 70.00%.

@@             Coverage Diff             @@
##           develop   #17974      +/-   ##
===========================================
- Coverage    62.88%   62.85%   -0.03%     
===========================================
  Files          755      755              
  Lines        67911    67924      +13     
  Branches      5987     5987              
===========================================
- Hits         42705    42695      -10     
- Misses       21779    21841      +62     
+ Partials      3427     3388      -39     
Flag Coverage Δ
server-mariadb 66.28% <66.66%> (-0.14%) ⬇️
server-ui 31.91% <33.33%> (+0.01%) ⬆️
ui-tests 50.96% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ankush ankush merged commit fbee80f into frappe:develop Aug 26, 2022
@ankush ankush deleted the rebuild_in_bg branch August 26, 2022 12:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2022
@ankush ankush added the backport version-14-hotfix backport to version 14 label Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant