removing realpath requirement for symbolically linked site directories #18313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
add-test-cases
ankush
added
security
and removed
add-test-cases
|
Hey thanks for sending this PR, we missed the use case of symlinking inside the site directory. Closing in favor of better alternate fix (which will address your use case too) #18316 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of us have sites where the
privateandpublicfolders are symbolically linked and shared across multiple machines (behind a load balancer). We mount a single datastore between machines which causes the directories or theis_safe_pathmethod to fail even though its perfectly valid.Removing the
os.path.realpathrequirement for thematchpathensures it works as designed, and also works for symbolically linked directories.