-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(file)!: dont handle case where existing file URL was re-attached in get_full_path
#18584
Conversation
get_full_path
get_full_path
c30044c
to
3c308b6
Compare
Same backport labels as #17250 have been added. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #18584 +/- ##
===========================================
- Coverage 63.07% 63.06% -0.01%
===========================================
Files 747 747
Lines 67410 67402 -8
Branches 5996 5996
===========================================
- Hits 42516 42505 -11
- Misses 21434 21437 +3
Partials 3460 3460
Flags with carried forward coverage won't be shown. Click here to find out more. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
@ankush Let's close this if we aren't looking to fix it as of now. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
The problem described in #17250 will only get solved for new attachments. It will continue for existing attachments.
That's okay, because
get_url
can be unreliable: