Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: use is_file_path_valid instead of is_safe_path" #18688

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

ankush
Copy link
Member

@ankush ankush commented Oct 31, 2022

breaks relinking existing file

#18316

@ankush ankush added Skip CI Doesn't run Ci for this PR. Run UI Tests Runs Server CI builds even if frontend changes not detected. labels Oct 31, 2022
@ankush ankush changed the title Revert "fix: use is_file_path_valid instead of is_safe_path" fix: re-upload existing file from fileuploader Oct 31, 2022
@ankush ankush changed the title fix: re-upload existing file from fileuploader Revert "fix: use is_file_path_valid instead of is_safe_path" Nov 1, 2022
@ankush ankush marked this pull request as ready for review November 1, 2022 07:10
@ankush ankush requested review from surajshetty3416 and a team as code owners November 1, 2022 07:10
@ankush ankush requested review from phot0n and removed request for a team November 1, 2022 07:10
@ankush ankush merged commit f0ab6cb into develop Nov 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
@ankush ankush deleted the revert-18316-fix-always-validate branch December 7, 2022 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Run UI Tests Runs Server CI builds even if frontend changes not detected. Skip CI Doesn't run Ci for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant