Change update parent check for communication #1885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes update parent so is dependant on replied option in status instead of open so replied can be removed to opt-out of update
| @@ -148,7 +148,7 @@ def update_parent_status(doc): | |||
|
|
|||
| status_field = parent.meta.get_field("status") | |||
|
|
|||
| if status_field and "Open" in (status_field.options or "").split("\n"): | |||
| if status_field and "Replied" in (status_field.options or "").split("\n"): | |||
There was a problem hiding this comment.
we should check both options "Open" and "Replied". Can you fix?
|
the primary reason for the change is to block the updating of docstatus from communication so if replied option is removed it doesnt update but still want open status |
gagaboy
added a commit
to gagaboy/frappe
that referenced
this pull request
Jul 21, 2016
* commit '9e305cc23709709986238f1d21b8dcd580de3ff0': (213 commits) [minor] dashboard fixes [fix] dashboard cleanup [fix] for offcanvas, fixes frappe/erpnext#5803 deleted offcanvas related files and code deleted offcanvas_left_sidebar.html close sidebar on link click comment out offcanvas related code [mobile ui] fixed navbar-breadcrumbs [fix] test [hot] fix accidental rename [minor] use replied option to opt-in for email status, fixes frappe#1885 [fix] dont update modified timestamp if called from post save methods [minor] re-rendered the headers while switching views [mobile ui] fixed frappe#5287 [fix] grid refresh issue, fixed frappe/erpnext#5781 [View] Switching between Image and List View from Sidebar [enhance] run actions in background doc.queue_action("submit") [cleanup] webforms [fix] angolan currency frappe#1828 [minor] fixed error for frappe#5782 and grid text editor must be text ...
shreyasp
pushed a commit
to shreyasp/frappe
that referenced
this pull request
Aug 1, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes update parent so is dependant on replied option in status instead of open so replied can be removed to opt-out of update