Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in web form if print format is empty getting error #19269

Merged
merged 2 commits into from Dec 13, 2022

Conversation

shariquerik
Copy link
Member

Issue: If Allow Print is checked and Print Format is not set it should use standard print format but it is giving error

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #19269 (55d3bea) into develop (b91354e) will decrease coverage by 1.52%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #19269      +/-   ##
===========================================
- Coverage    64.58%   63.06%   -1.53%     
===========================================
  Files          754      754              
  Lines        70352    70352              
  Branches      6117     6117              
===========================================
- Hits         45440    44370    -1070     
- Misses       21441    22478    +1037     
- Partials      3471     3504      +33     
Flag Coverage Δ
server ?
server-ui 31.69% <ø> (+0.02%) ⬆️
ui-tests 51.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@shariquerik shariquerik merged commit 6dab439 into frappe:develop Dec 13, 2022
@shariquerik shariquerik deleted the web-form-print-format-fix branch December 13, 2022 13:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant