feat: add parameters language and letter_head to download_pdf
#19284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barredterra
requested review from
shariquerik
and removed request for
a team
github-actions
bot
added
the
add-test-cases
barredterra
added
backport version-14-hotfix
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #19284 +/- ##
===========================================
- Coverage 64.62% 64.56% -0.06%
===========================================
Files 754 754
Lines 70430 70764 +334
Branches 6117 6117
===========================================
+ Hits 45513 45690 +177
- Misses 21440 21601 +161
+ Partials 3477 3473 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
shariquerik
approved these changes
Dec 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to specify language and letter head when printing via
download_pdf().Previously, it just used the default letter head and the current user's language, with no option to change that.
Required for frappe/erpnext#33339