Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove "All" permission on workspace (Backport #19496) #19520

Merged
merged 6 commits into from
Jan 9, 2023

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Jan 8, 2023

  • Backport of fix: remove "All" permission for Workspace #19496: 38b0327
  • The menu button "Toggle Sidebar" had no visible effect, therefore I removed it. Toggling the sidebar still works via the sandwich on the left. 3f070ad
  • The menu buttons were not aligned with workspace content on large screens. Fixed this in ec6b89f. Workspaces with scrollbar are still a bit off, due to the additional width of the scrollbar, but less than before. (d202d10)
    Before:
    before
    After:
    after

@barredterra barredterra requested review from a team and phot0n and removed request for a team January 8, 2023 18:11
@barredterra barredterra changed the title fix: remove "All" permission on workspace fix: remove "All" permission on workspace (Backport #19496) Jan 8, 2023
@shariquerik shariquerik merged commit 3d3aafc into frappe:version-13-hotfix Jan 9, 2023
@barredterra barredterra deleted the workspace-perms branch January 9, 2023 12:27
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 13.47.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants