feat: rearranging standard fields in customize form

[dj12djdjs]

continuation of: #19452

Customize Form now supports reordering all fields (including "standard" ones) 🎉

Implementation

A new property setter called field_order has been introduced. When meta.sort_fields is called following is done:

• if field order doesn't exist, existing algorithm applies

If field order exists:

• field order is "cleaned" for dead fields
• if it matches size of fields, new order is immediately updated (best case scenario)

In case new fields are present in doctype, but aren't in cleaned field order:

• if standard fields at the top of the DocType's fields table are absent in the field order, a list is created of such fields.
• if there are atleast some standard fields in field order, the above list is prepended to field order, else, the above list becomes field order (essentially field order gets invalidated)
• remaining fields are inserted using following logic:
  • insert_after for custom fields (same as before)
  • computed insert_after for standard fields (this is currently done based on the DocType's fields table)

Additional implementation (if reviewer requests it)

• Delete invalid field_order (if no standard fields found) by enqueue-ing a DB call
• Update field order (when re-computed) by enqueue-ing a DB call
• Notify system managers if field order needs update. The "computed insert after" logic isn't 100% accurate so it can be beneficial if user reviews the order and manually fixes as needed (needs above update feature as well - to prevent duplicate notifications)

cc: @ankush @surajshetty3416

TODO (after initial review)

• tests for "computed" logic
• support for form builder
• documentation

To be backported together with #20168

[codecov]

Codecov Report

Merging #19822 (5ef66f3) into develop (7042dca) will increase coverage by 0.12%.
The diff coverage is 54.54%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #19822      +/-   ##
===========================================
+ Coverage    63.87%   64.00%   +0.12%     
===========================================
  Files          761      759       -2     
  Lines        68844    68755      -89     
  Branches      6224     6200      -24     
===========================================
+ Hits         43977    44007      +30     
+ Misses       21320    21256      -64     
+ Partials      3547     3492      -55     

Flag	Coverage Δ
server	68.91% <54.90%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[pmjd-code]

I can offer to help with documentation if needed, would be great to see this implemented.

[dj12djdjs]

I can offer to help with documentation if needed, would be great to see this implemented.

@pmjd-code Thank you, I think we better wait until code changes are approved before writing documentation.

[pmjd-code]

The Form Builder is great and this feature would really help in customising apps.
I know there is a lot going on and limited resources but does anyone know if this feature likely to make it soon or is it more likely months away?

[sagarvora]

I will complete the remaining TODOs over the weekend and merge this.

If anyone has inputs on the additional implementation points above, they'd be greatly appreciated.

[sagarvora]

I haven't been able to get this done. Some other projects that are more critical are taking longer. I don't have a new ETA as of now.

[pmjd-code]

@sagarvora I understand. Thank you for the update and all of the hard work from you and @dj12djdjs on this.

If it is only the 4 files listed on thir PR needed to implement, I will probably try and add them in my own install so I can customise my installation of ERPnext more easily.

Thanks

[ankush]

@dj12djdjs @sagarvora this feels okay for first cut. Whatever the caveats maybe, all those exist for current code too.

Few things we can add maybe is:

• Give a "Reset Layout" button to just delete the property setter (and nothing else), This will basically go back to the previous behaviour. fix(UX): let people reset layout back to original #21290

[sagarvora]

support for form builder added via #21297