Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wkhtmltopdf logging #19935

Merged
merged 2 commits into from
May 24, 2023
Merged

Conversation

casesolved-co-uk
Copy link
Contributor

@casesolved-co-uk casesolved-co-uk commented Feb 5, 2023

PDF logging to pick up problems:

2022-12-05 08:17:06,942 INFO wkhtmltopdf Loading pages (1/6)
Warning: Failed to load http://testing/assets/css/printview.css (ignore)
Warning: Failed to load http://testing/assets/css/printview.css (ignore)
Counting pages (2/6)
Resolving links (4/6)
Loading headers and footers (5/6)
Warning: Failed to load http://testing/assets/css/printview.css (%
ignore)
Printing pages (6/6)
Done

Loading pages (1/6)
Warning: Failed to load http://localhost/assets/frappe/bg.jpg (ignore)
Warning: Failed to load http://localhost/assets/frappe/test.jpg (ignore)
Counting pages (2/6)
Resolving links (4/6)
Loading headers and footers (5/6)
Printing pages (6/6)
Done

no-docs
version-14-hotfix

@casesolved-co-uk casesolved-co-uk requested review from a team and phot0n and removed request for a team February 5, 2023 03:30
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Feb 5, 2023
@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Merging #19935 (73fdb55) into develop (98e8b6d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #19935      +/-   ##
===========================================
+ Coverage    63.92%   63.93%   +0.01%     
===========================================
  Files          759      759              
  Lines        68780    68803      +23     
  Branches      6219     6219              
===========================================
+ Hits         43967    43990      +23     
  Misses       21273    21273              
  Partials      3540     3540              
Flag Coverage Δ
server 68.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@stale
Copy link

stale bot commented Feb 25, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@casesolved-co-uk
Copy link
Contributor Author

@phot0n ?

@ankush ankush removed the add-test-cases Add test case to validate fix or enhancement label Feb 27, 2023
@stale stale bot added the inactive label Mar 6, 2023
@frappe frappe deleted a comment from stale bot Mar 7, 2023
@phot0n phot0n self-assigned this Mar 7, 2023
@casesolved-co-uk casesolved-co-uk force-pushed the wkhtmltopdf_log_v14 branch 2 times, most recently from 7be9553 to c8c1e15 Compare March 8, 2023 15:27
@stale stale bot removed the inactive label Mar 8, 2023
@ankush ankush added the hotfix label Mar 17, 2023
@casesolved-co-uk casesolved-co-uk force-pushed the wkhtmltopdf_log_v14 branch 4 times, most recently from f6ad4d0 to 7f21fa3 Compare March 25, 2023 21:07
@ankush ankush merged commit 6354a01 into frappe:develop May 24, 2023
18 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants