Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove deprecated timezone utils #20255

Merged
merged 2 commits into from Mar 6, 2023

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Mar 5, 2023

@barredterra barredterra requested review from surajshetty3416 and a team as code owners March 5, 2023 15:07
@barredterra barredterra requested review from shariquerik, phot0n and a team and removed request for a team, surajshetty3416 and shariquerik March 5, 2023 15:07
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Mar 5, 2023
@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Merging #20255 (0a6c2cf) into develop (c099b67) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 0a6c2cf differs from pull request most recent head db92d1c. Consider uploading reports for the commit db92d1c to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #20255      +/-   ##
===========================================
- Coverage    63.90%   63.90%   -0.01%     
===========================================
  Files          757      757              
  Lines        68695    68689       -6     
  Branches      6176     6176              
===========================================
- Hits         43900    43896       -4     
+ Misses       21269    21267       -2     
  Partials      3526     3526              
Flag Coverage Δ
server 68.91% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@phot0n phot0n changed the title feat!: remove deprecated timezone utils refactor!: remove deprecated timezone utils Mar 6, 2023
@phot0n phot0n merged commit 036e1c9 into frappe:develop Mar 6, 2023
@barredterra barredterra deleted the remove-deprecated-methods branch March 6, 2023 14:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
add-test-cases Add test case to validate fix or enhancement do not backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants