Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Workflow Builder #20880

Merged
merged 55 commits into from May 10, 2023
Merged

feat: Workflow Builder #20880

merged 55 commits into from May 10, 2023

Conversation

shariquerik
Copy link
Member

@shariquerik shariquerik commented May 2, 2023 •
edited

Screen.Recording.2023-05-03.at.1.12.14.PM.mov

NOTE: There are many small UI/UX fixes remaining and have more scope to position actions and edges while doing some actions.

Banner with GIF
New Workflow
image

Edit Workflow
image

Button to open workflow builder on the list view
image

no-docs

@shariquerik
feat: workflow builder
aa3b6d3 
created page with vue setup
@shariquerik
fix: workflow creating/editing dialog
289c774
@shariquerik
fix: try workflow builder button in workflow doc
96057eb
@shariquerik
fix: vueflow & pinia setup
c61be69
@shariquerik
fix: basic vueflow using custom node & edge
42247bc
@shariquerik
fix: action node between to state node on connect
00b80aa 
also added connection line
@shariquerik
fix: zoom in/out and fit buttons
17c613a
@shariquerik
fix: updatable edge position with validation on connect & on edge update
4859a53
@shariquerik
feat: undo/redo feature
abcc955
@shariquerik
fix: drag to add new state
b004a28
@shariquerik
fix: render states & transition by fetching workflow data
f258ca0
@shariquerik
fix: also show role access for transition
a10cf8d
@shariquerik
fix: save_changes in to workflow_data field
3d0af4b
@shariquerik
fix: clean workflow_data before saving
654c941
@shariquerik
fix: cmd/ctrl+s to save workflow
13e5031
@shariquerik
fix: added sidebar to show workflow data
bcfd07b
@shariquerik
fix: resizable sidebar
8e9c2aa
@shariquerik
fix: sidebar header
5894286
@shariquerik
fix: show state/transition data on sidebar on click
9ab905c
@shariquerik
fix: select state when added
1384b65
@shariquerik
fix: form_builder undo_redo event is interfering with workflow_builde…
9037c41 
…r's undo_redo event
@shariquerik
fix: also include selected in undo redo object
b6aa76b
@shariquerik
fix: select action on connecting two state
277c5e1
@shariquerik
fix: show Draft/Submitted/Cancelled instead of 0/1/2 in doc_status dr…
5b21db8 
…opdown
@shariquerik
fix: update states & transition table on save
a405f99
@shariquerik
fix: loose focus when clicked outside container
1622f8d
@shariquerik
fix: delete node only if backspace is clicked not meta/ctrl + backspace
befde64
@shariquerik
fix: deselect all nodes while adding new state
b786119
@shariquerik
fix: select entire transition on edge/acess role/action click also de…
43dcda0 
…select on blur
@shariquerik
fix: only allow to select remaining states
10c48a5
@codecov
Copy link

codecov bot commented May 10, 2023 •
edited

Codecov Report

Merging #20880 (3736aaa) into develop (90d03d9) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 3736aaa differs from pull request most recent head 6dfcd52. Consider uploading reports for the commit 6dfcd52 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #20880   +/-   ##
========================================
  Coverage    63.91%   63.91%           
========================================
  Files          761      761           
  Lines        68873    68873           
  Branches      6225     6225           
========================================
+ Hits         44021    44022    +1     
+ Misses       21327    21326    -1     
  Partials      3525     3525
Flag Coverage Δ
server 68.91% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@shariquerik
Copy link
Member Author

shariquerik commented May 10, 2023 •
edited

  • Better sidebar layout for better UX
  • Better State/Action/Edge positioning while doing an action like connecting two states etc
  • UI test
  • Docs
  • Update the GIFs on the banner with the latest design

Will cover the above mentioned feat/fixes in a separate PR

@shariquerik shariquerik marked this pull request as ready for review May 10, 2023 12:02
@shariquerik shariquerik requested a review from a team as a code owner May 10, 2023 12:02
@shariquerik shariquerik requested review from phot0n and removed request for a team May 10, 2023 12:02
@shariquerik shariquerik removed the add-test-cases Add test case to validate fix or enhancement label May 10, 2023
@shariquerik shariquerik merged commit cf950b8 into frappe:develop May 10, 2023
17 of 19 checks passed
@shariquerik shariquerik deleted the workflow-builder branch May 10, 2023 13:17
@michellealva
Copy link
Contributor

michellealva commented May 11, 2023 •
edited

@shariquerik some observations:

  • I tried adding a condition to an action via the workflow builder. It didn't work. In the normal view, the condition didn't show up.
  • The save button looks the same even when changes are made. I was unable to understand if I even made any changes.
  • Getting the following error on adding a new state.
image

@ankush ankush mentioned this pull request May 12, 2023
Open
3 tasks
@shariquerik shariquerik restored the workflow-builder branch May 17, 2023 11:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phot0n phot0n Awaiting requested review from phot0n phot0n is a code owner automatically assigned from frappe/frappe-review-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shariquerik @michellealva