-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: What's New
#21014
Merged
Merged
feat: What's New
#21014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
add-test-cases
Add test case to validate fix or enhancement
label
May 16, 2023
BreadGenie
commented
May 16, 2023
ankush
reviewed
May 16, 2023
surajshetty3416
added
the
add-description
Details or Reason for the change. Also add screenshots and animated GIF if applicable
label
May 17, 2023
ankush
reviewed
May 18, 2023
Codecov Report
@@ Coverage Diff @@
## develop #21014 +/- ##
===========================================
- Coverage 61.91% 59.49% -2.42%
===========================================
Files 767 770 +3
Lines 73173 79203 +6030
Branches 6314 6252 -62
===========================================
+ Hits 45303 47123 +1820
- Misses 24255 28529 +4274
+ Partials 3615 3551 -64
Flags with carried forward coverage won't be shown. Click here to find out more. |
`frappe.call` supports plumbing args to the called fn.
I've been thinking about a user-wise "notice queue" of some kind which shows up as popups after logging in. We did a specific implementation in India Compliance: |
BreadGenie
requested review from
a team and
phot0n
and removed request for
a team
May 29, 2023 08:00
phot0n
reviewed
May 31, 2023
BreadGenie
commented
Apr 8, 2024
- implicit limit - bench level cache for each app
- Remove API call - Remove notification setting, don't think we need this
ankush
approved these changes
Apr 8, 2024
ankush
added
the
defer backport
Backports for some PR are deferred for a week or two to test them properly before releasing
label
Apr 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
defer backport
Backports for some PR are deferred for a week or two to test them properly before releasing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a
What's New
section on the notification tab of Desk where new updates of apps can be published with the help ofget_changelog_feed
hook.Sample Screenshot