Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: What's New #21014

Merged
merged 40 commits into from
Apr 8, 2024
Merged

feat: What's New #21014

merged 40 commits into from
Apr 8, 2024

Conversation

BreadGenie
Copy link
Member

@BreadGenie BreadGenie commented May 16, 2023

Introduces a What's New section on the notification tab of Desk where new updates of apps can be published with the help of get_changelog_feed hook.

Sample Screenshot

@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label May 16, 2023
frappe/hooks.py Outdated Show resolved Hide resolved
@ankush ankush self-assigned this May 16, 2023
frappe/hooks.py Outdated Show resolved Hide resolved
@surajshetty3416 surajshetty3416 added the add-description Details or Reason for the change. Also add screenshots and animated GIF if applicable label May 17, 2023
frappe/hooks.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #21014 (49b5ad8) into develop (3d10073) will decrease coverage by 2.42%.
Report is 2 commits behind head on develop.
The diff coverage is 3.92%.

@@             Coverage Diff             @@
##           develop   #21014      +/-   ##
===========================================
- Coverage    61.91%   59.49%   -2.42%     
===========================================
  Files          767      770       +3     
  Lines        73173    79203    +6030     
  Branches      6314     6252      -62     
===========================================
+ Hits         45303    47123    +1820     
- Misses       24255    28529    +4274     
+ Partials      3615     3551      -64     
Flag Coverage Δ
server 65.41% <3.92%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sagarvora
Copy link
Collaborator

I've been thinking about a user-wise "notice queue" of some kind which shows up as popups after logging in. We did a specific implementation in India Compliance:

https://github.com/resilient-tech/india-compliance/blob/c3aab4c056df4c0ca44f42d99b4c9507ef2f39fb/india_compliance/patches/v14/set_default_for_audit_trail_notification.py#L22

@BreadGenie BreadGenie marked this pull request as ready for review May 29, 2023 08:00
@BreadGenie BreadGenie requested review from a team and phot0n and removed request for a team May 29, 2023 08:00
@ankush ankush marked this pull request as draft April 8, 2024 11:44
@ankush ankush added the Skip CI Doesn't run Ci for this PR. label Apr 8, 2024
@ankush ankush removed hotfix Skip CI Doesn't run Ci for this PR. labels Apr 8, 2024
@ankush ankush marked this pull request as ready for review April 8, 2024 13:07
- Remove API call
- Remove notification setting, don't think we need this
@ankush ankush enabled auto-merge April 8, 2024 13:25
@ankush ankush merged commit 9dad8b1 into frappe:develop Apr 8, 2024
21 of 23 checks passed
@BreadGenie BreadGenie deleted the whats-new branch April 8, 2024 13:39
@ankush ankush added the defer backport Backports for some PR are deferred for a week or two to test them properly before releasing label Apr 8, 2024
@frappe frappe unlocked this conversation Apr 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defer backport Backports for some PR are deferred for a week or two to test them properly before releasing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants