Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect caching of is_owner permissions #21048

Merged
merged 1 commit into from
May 19, 2023

Commits on May 19, 2023

  1. fix: incorrect caching of is_owner permissions

    - Create a doctype
    - Pick any role and only allow owner to create, read, write.
    - after_insert hook re-save the document
    - This will fail because there's a function call to `frappe.only_has_select_perm` which doesn't pass the is_owner, this is likely acceptable if document is not available.
    
    Fix: cache should be separate for is_owner
    
    Triggered from but not caused by frappe#20810
    ankush committed May 19, 2023
    Configuration menu
    Copy the full SHA
    116f74c View commit details
    Browse the repository at this point in the history