feat: webhook timeout #21410
Merged
feat: webhook timeout #21410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
add-test-cases
ankush
reviewed
Jun 17, 2023
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #21410 +/- ##
===========================================
- Coverage 63.89% 63.83% -0.06%
===========================================
Files 765 765
Lines 69365 69364 -1
Branches 6276 6276
===========================================
- Hits 44318 44276 -42
- Misses 21440 21513 +73
+ Partials 3607 3575 -32
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
would be nice to have a test for this - merged before that :P @dj12djdjs could you please add that in a new pr? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case it is known a certain request will take more than 5 seconds to process the maintainer of the webhook can increase the timeout limit.
no-docs