build(deps): update redis client to v4 in legacy mode

[blaggacao]

@ankush Hopefully this is a more palatable version of #20925 😄 and the further refactoring to actually use the v4 api of that PR can then be added eventually as a second step (if needed).

The version bump also requires frappe/bench#1466 due to localhost being interpreted as ipv6 ::1.

I added a temp fix for CI that must be reverted once that bench PR is merged and has duly propagated.

[codecov]

Codecov Report

Merging #21548 (fa6c389) into develop (00e5dab) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #21548   +/-   ##
========================================
  Coverage    63.86%   63.86%           
========================================
  Files          765      765           
  Lines        69353    69353           
  Branches      6271     6271           
========================================
  Hits         44291    44291           
  Misses       21487    21487           
  Partials      3575     3575           

Flag	Coverage Δ
server	69.04% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[ankush]

@blaggacao the fix in bench wont fix existing installs. What breaks with localhost?

It seems to work fine for me. Can you share some error/traceback?

[blaggacao]

@ankush I think this might be a better fix across "affected" * node versions, then.

The issue is ERRCONNECT on ::1.

* IMO, it's not unreasonable to assume localhost as ::1, it's part of the standard, after all.

[ankush]

@surajshetty3416 we might need the fix to make node work on systems which are preferring ipv6 (idk if there's any real cost to forcing ipv4 in code since we are using it only on localhost 🤷)

[blaggacao]

Going forward, I'd recommend to not use dns (i.e. localhost), but the raw ip (i.e. 127.0.0.1), since on some container environments (prominently minimal ones) localhost resolution does not work, even if runc / containerd try hard to inject correct resolution.

It's also a good way to avoid 'hard' problems. 😄

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.