fix: remove unused variable and fetching of the "doc before save" #21599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`get_doc_before_save` gets called and stored on a variable which is never used in this function and can thus be removed
Mutantpenguin
requested review from
a team and
phot0n
and removed request for
a team
ankush
approved these changes
Jul 8, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
## [13.57.5](v13.57.4...v13.57.5) (2023-07-11) ### Bug Fixes * remove unused variable and fetching of the "doc before save" ([#21599](#21599)) ([c6a24b5](c6a24b5))
|
🎉 This PR is included in version 13.57.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_doc_before_savegets called and stored on a variable which is never used in this function and can thus be removedI checked this in frappe 14 and this line doesn't exist there.