-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(dx): let developers know that they need to enable index on links #21745
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #21745 +/- ##
===========================================
+ Coverage 61.88% 64.05% +2.16%
===========================================
Files 765 763 -2
Lines 72988 69526 -3462
Branches 6292 6281 -11
===========================================
- Hits 45170 44536 -634
+ Misses 24275 21455 -2820
+ Partials 3543 3535 -8
Flags with carried forward coverage won't be shown. Click here to find out more. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
Many edge cases which can't be checked on-the-fly. Best to just notify developer that they should enable indexing.
9aca1fc
to
c83b8b2
Compare
I ran this and it enabled way too many indexes (not a lot of them required indexing 🥴 ), we need a better solution for all link/dynamic link indexing 😔 For now I've made this a nudge to developer, they can enable it if required. |
For DocTypes linked on a dashboard,
get_open_count()
and (via click) the list view filtered by this link will be called many times. Hence, indexing likely pays off.