feat: Added Re-run in Console Button in Console Log Doctype #21825
Conversation
RitvikSardana
requested review from
surajshetty3416
and removed request for
a team
|
the type of script would also need to be recorded in the console log so that it can be reloaded back appropriately - currently we only support 2 types: sql & python (and I'm not sure if there are any future plans for adding new types) so a checkbox might suffice OR we can try to parse the script and see if it's valid python (while reloading in sysconsole) and set the type appropriately |
|
@phot0n |
shariquerik
added
the
add-description
| // refresh: function(frm) { | ||
| // } | ||
| refresh: function (frm) { | ||
| frm.add_custom_button(__("Reload in Console"), () => { |
There was a problem hiding this comment.
| frm.add_custom_button(__("Reload in Console"), () => { | |
| frm.add_custom_button(__("Re-run in Console"), () => { |
Better naming IMO.
|
The solution works but it is causing one more issue, it is opening system-console/new and because of that the action button 'Logs' is missing Maybe try in the way we do in customize form. We store the doctype name in local and repopulate when it is loaded |
|
👀 |
RitvikSardana
changed the title
RitvikSardana
changed the title
| frm.add_custom_button(__("Re-Run in Console"), () => { | ||
| window.localStorage.setItem("system_console_code", frm.doc.script); | ||
| window.localStorage.setItem("system_console_type", frm.doc.type); | ||
| window.location.href = "/app/system-console"; |
[skip ci]
Added this button in Console Log Doctype.
Now the user can click on the button and they will be redirected to System Console and code and type will be pre populated.
System.Console.mov
What Changed:
no-docs