Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Made Set Password Page Better #21846

Conversation

RitvikSardana
Copy link
Contributor

@RitvikSardana RitvikSardana commented Jul 28, 2023

Issue:
image

Both good to go & password does not match messages were shown at the same time in the "Set Password Page", which is a bad UX as it tells us everything is good even though the passwords aren't same.

Solution:
image

Update.Password.mov

Functionalities:

  1. Old Password and New password can't be same, if same error msg will be shown
  2. New password Strength Feedback
  3. New Password ≠ Confirm Password then passwords don't match error will be shown.
  4. If New Password == Confirm password and old password ≠ new password then Submit button will be enabled else it will be disabled.

@RitvikSardana RitvikSardana self-assigned this Jul 28, 2023
@RitvikSardana RitvikSardana linked an issue Jul 28, 2023 that may be closed by this pull request
Copy link
Member

@shariquerik shariquerik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2023-07-29.at.2.40.09.AM.mov

As you can see in video, after getting the "Password do not match" error I fixed my password but it won't go also the old message telling
This is a very common password.
Hint: Include symbols, numbers and capital letters in the password

it should come back again

Try, different scenarios user can do, and try to fix the overall UX

@shariquerik shariquerik self-assigned this Jul 28, 2023
@RitvikSardana
Copy link
Contributor Author

@shariquerik
have made the required changes and along with it added button disable functionality also for better UX.

@shariquerik
Copy link
Member

@RitvikSardana Looks great, just one more thing to add if the old password and a new password are the same, show it cannot be the same message

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #21846 (27426f7) into develop (6e94cd2) will decrease coverage by 0.49%.
Report is 87 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #21846      +/-   ##
===========================================
- Coverage    61.88%   61.39%   -0.49%     
===========================================
  Files          765      765              
  Lines        72937    74798    +1861     
  Branches      6282     6292      +10     
===========================================
+ Hits         45134    45922     +788     
- Misses       24246    25293    +1047     
- Partials      3557     3583      +26     
Flag Coverage Δ
server-ui 28.12% <ø> (+0.03%) ⬆️
ui-tests 51.41% <ø> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@shariquerik shariquerik merged commit eebbcd0 into frappe:develop Aug 7, 2023
14 of 15 checks passed
@shariquerik shariquerik added the backport version-14-hotfix backport to version 14 label Aug 7, 2023
shariquerik added a commit that referenced this pull request Aug 7, 2023
…-21846

fix: Made Set Password Page Better (backport #21846)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better Set Password page
2 participants