-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Made Set Password Page Better #21846
fix: Made Set Password Page Better #21846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screen.Recording.2023-07-29.at.2.40.09.AM.mov
As you can see in video, after getting the "Password do not match" error I fixed my password but it won't go also the old message telling
This is a very common password.
Hint: Include symbols, numbers and capital letters in the password
it should come back again
Try, different scenarios user can do, and try to fix the overall UX
@shariquerik |
@RitvikSardana Looks great, just one more thing to add if the old password and a new password are the same, show |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #21846 +/- ##
===========================================
- Coverage 61.88% 61.39% -0.49%
===========================================
Files 765 765
Lines 72937 74798 +1861
Branches 6282 6292 +10
===========================================
+ Hits 45134 45922 +788
- Misses 24246 25293 +1047
- Partials 3557 3583 +26
Flags with carried forward coverage won't be shown. Click here to find out more. |
…-21846 fix: Made Set Password Page Better (backport #21846)
Issue:
Both good to go & password does not match messages were shown at the same time in the "Set Password Page", which is a bad UX as it tells us everything is good even though the passwords aren't same.
Solution:
Update.Password.mov
Functionalities: