Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Report Builder): print all filters #21903

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Aug 2, 2023

Print all filters in report builder:

Bildschirmfoto 2023-08-02 um 11 51 44

Bildschirmfoto 2023-08-02 um 11 51 25

German translations for printed filters:

Bildschirmfoto 2023-08-02 um 11 58 07

no-docs

@barredterra barredterra requested review from a team and maharshivpatel and removed request for a team August 2, 2023 10:03
@barredterra barredterra added the backport version-14-hotfix backport to version 14 label Aug 2, 2023
@barredterra barredterra changed the title print report filters feat(Report Builder): print all filters Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #21903 (dd9a778) into develop (67a32bd) will increase coverage by 0.08%.
Report is 3 commits behind head on develop.
The diff coverage is n/a.

❗ Current head dd9a778 differs from pull request most recent head b9cdee8. Consider uploading reports for the commit b9cdee8 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #21903      +/-   ##
===========================================
+ Coverage    61.65%   61.74%   +0.08%     
===========================================
  Files          765      765              
  Lines        72987    72976      -11     
  Branches      6292     6290       -2     
===========================================
+ Hits         45002    45059      +57     
+ Misses       24381    24328      -53     
+ Partials      3604     3589      -15     
Flag Coverage Δ
server 65.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ankush ankush merged commit 76c6924 into frappe:develop Aug 8, 2023
16 of 20 checks passed
ankush added a commit that referenced this pull request Aug 8, 2023
…-21903

feat(Report Builder): print all filters (backport #21903)
@barredterra barredterra deleted the print-report-filters branch August 8, 2023 08:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants