Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: set request_ip when testing reset_password #21937

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

sagarvora
Copy link
Contributor

@sagarvora sagarvora commented Aug 5, 2023

Fix required due to #21929

Alternate fixes:

  • set a flag like frappe.flags.ignore_rate_limiter
  • change rate limiter implementation to look for frappe.local.http_request instead

@sagarvora sagarvora requested review from a team and maharshivpatel and removed request for a team August 5, 2023 18:25
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #21937 (498911b) into develop (7aed89a) will increase coverage by 0.00%.
Report is 3 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21937   +/-   ##
========================================
  Coverage    61.87%   61.88%           
========================================
  Files          765      765           
  Lines        73000    73000           
  Branches      6292     6292           
========================================
+ Hits         45172    45173    +1     
+ Misses       24264    24263    -1     
  Partials      3564     3564           
Flag Coverage Δ
server 65.25% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ankush ankush merged commit e877d92 into frappe:develop Aug 7, 2023
19 checks passed
sagarvora added a commit that referenced this pull request Aug 19, 2023
* test: set `request_ip` when testing `reset_password`

* test: increase rate limit temporarily while testing `reset_password`
sagarvora added a commit that referenced this pull request Aug 19, 2023
* test: set `request_ip` when testing `reset_password`

* test: increase rate limit temporarily while testing `reset_password`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants