Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disallow unsafe attrs in jinja env #22128

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

sagarvora
Copy link
Contributor

@sagarvora sagarvora commented Aug 20, 2023

No description provided.

@sagarvora sagarvora requested review from a team and surajshetty3416 and removed request for a team August 20, 2023 16:57
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Aug 20, 2023
@sagarvora sagarvora removed the add-test-cases Add test case to validate fix or enhancement label Aug 20, 2023
@sagarvora sagarvora changed the title fix: disallow unsafe attrs in jinja fix: disallow unsafe attrs in jinja env Aug 20, 2023
@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Merging #22128 (01c2697) into develop (8243d3d) will decrease coverage by 0.06%.
Report is 10 commits behind head on develop.
The diff coverage is 87.50%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #22128      +/-   ##
===========================================
- Coverage    62.10%   62.04%   -0.06%     
===========================================
  Files          767      767              
  Lines        72993    73139     +146     
  Branches      6302     6302              
===========================================
+ Hits         45330    45380      +50     
- Misses       24215    24311      +96     
  Partials      3448     3448              
Flag Coverage Δ
server 65.39% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@mergify mergify bot merged commit 2a086cf into frappe:develop Aug 21, 2023
25 checks passed
ankush added a commit that referenced this pull request Aug 21, 2023
…-22128

fix: disallow unsafe attrs in jinja env (backport #22128)
ankush added a commit that referenced this pull request Aug 21, 2023
…-22128

fix: disallow unsafe attrs in jinja env (backport #22128)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants