Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding utf-8-sig to address UTF files with BOM #22178

Closed

Conversation

tinodj
Copy link

@tinodj tinodj commented Aug 24, 2023

Closes #22151.

@tinodj tinodj requested review from a team and shariquerik and removed request for a team August 24, 2023 09:44
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Aug 24, 2023
@ankush ankush changed the title Adding utf-8-sig to address UTF files with BOM. Addressing issue #22151. fix: Adding utf-8-sig to address UTF files with BOM Aug 24, 2023
@ankush
Copy link
Member

ankush commented Aug 24, 2023

@tinodj can you share a test file? I don't have access to windows machine.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #22178 (0fd67f8) into develop (8f7a4f6) will decrease coverage by 0.33%.
Report is 33 commits behind head on develop.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #22178      +/-   ##
===========================================
- Coverage    62.12%   61.79%   -0.33%     
===========================================
  Files          767      767              
  Lines        73033    74388    +1355     
  Branches      6303     6303              
===========================================
+ Hits         45373    45971     +598     
- Misses       24242    24999     +757     
  Partials      3418     3418              
Flag Coverage Δ
server 65.38% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@stale
Copy link

stale bot commented Sep 9, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Sep 9, 2023
@stale stale bot closed this Sep 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
add-test-cases Add test case to validate fix or enhancement inactive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add utf-8-sig when reading csv for import or do something else to remove BOM character
2 participants