Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UX): Add a subject field. #22638

Closed
wants to merge 1 commit into from
Closed

Conversation

bosue
Copy link
Contributor

@bosue bosue commented Oct 5, 2023

Fixes #22547.
Fixes #22632.

@bosue bosue requested a review from a team as a code owner October 5, 2023 17:01
@bosue bosue requested review from surajshetty3416 and removed request for a team October 5, 2023 17:01
@bosue bosue marked this pull request as draft October 5, 2023 17:11
frappe/desk/doctype/todo/todo.json Outdated Show resolved Hide resolved
frappe/desk/doctype/todo/todo.json Outdated Show resolved Hide resolved
@bosue
Copy link
Contributor Author

bosue commented Oct 6, 2023

@ssuda: Thanks for your review! We may not yet be there, but getting closer.

If we want to remove the description field from the list view – and I think we should – then we probably need an upgrade patch copying over descriptions – stripped to plain text – to the new subject field.

Unit tests need another tweak as well. Will look into it as soon as I can find some time.

Copy link
Collaborator

@barredterra barredterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preferred implementation approach: #22632 (comment)

@stale
Copy link

stale bot commented Oct 20, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Oct 20, 2023
@bosue
Copy link
Contributor Author

bosue commented Oct 21, 2023

Maybe we can do both. Stripping the html is a bugfix that can be backported to previous major versions. So this should be a priority. Introducing the subject field could be a breaking feature for a future major version.

Originally posted by @barredterra in #22632 (comment)

@stale stale bot removed the inactive label Oct 21, 2023
Copy link

stale bot commented Nov 4, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Nov 4, 2023
@bosue bosue closed this Nov 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a (required) “Subject“ field to ToDo Wrong listview render
3 participants