Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Footer Address not showing in website #2287

Merged
merged 2 commits into from
Nov 11, 2016
Merged

Fix for Footer Address not showing in website #2287

merged 2 commits into from
Nov 11, 2016

Conversation

shubhamgupta123
Copy link
Contributor

This is a probable fix for #2267
Due to earlier condition, only either copyright or the footer address was showing.
This is my first pull request. Kindly merge if everything seems right.

This is a probable fix for #2267
Due to earlier condition, only either copyright or the footer address was showing.
This is my first pull request. Kindly merge if everything seems right.
Copy link
Contributor

@manassolanki manassolanki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please insert a linebreak tag (br) between copyright and footer_address.

@manassolanki manassolanki merged commit b485916 into frappe:develop Nov 11, 2016
@manassolanki
Copy link
Contributor

Congrats on your first PR.
Keep contributing...!!!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants