Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search_link fails when txt contains parentheses #22892

Merged
merged 8 commits into from
Jan 16, 2024

Conversation

ssuda
Copy link
Contributor

@ssuda ssuda commented Oct 24, 2023

fixes: #22891, #22917

@ssuda ssuda requested review from a team and ankush and removed request for a team October 24, 2023 17:12
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #22892 (179941e) into develop (d92f74f) will increase coverage by 8.53%.
Report is 27 commits behind head on develop.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop   #22892      +/-   ##
===========================================
+ Coverage    62.19%   70.72%   +8.53%     
===========================================
  Files          770      494     -276     
  Lines        73806    43357   -30449     
  Branches      6364        0    -6364     
===========================================
- Hits         45904    30666   -15238     
+ Misses       24279    12691   -11588     
+ Partials      3623        0    -3623     
Flag Coverage Δ
server 70.72% <66.66%> (-0.02%) ⬇️
server-ui ?
ui-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@devarshi-007
Copy link

devarshi-007 commented Oct 26, 2023

Hello, How this pr suppose to fix #22917 ? Can you please tell me so I can understand because as discuss in issue, it is because of db_query's apply_fieldlevel_read_permissions().

@ssuda ssuda force-pushed the fix-search-txt-paren branch 2 times, most recently from bc64acb to 143d89b Compare October 26, 2023 13:56
@ssuda ssuda marked this pull request as draft October 26, 2023 14:12
@ssuda ssuda marked this pull request as ready for review October 30, 2023 17:05
Copy link

stale bot commented Nov 14, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Nov 14, 2023
@stale stale bot closed this Nov 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2023
@rmehta rmehta reopened this Jan 8, 2024
@stale stale bot removed the inactive label Jan 8, 2024
@ankush ankush added defer backport Backports for some PR are deferred for a week or two to test them properly before releasing and removed add-test-cases Add test case to validate fix or enhancement labels Jan 16, 2024
frappe/desk/reportview.py Outdated Show resolved Hide resolved
@ankush ankush enabled auto-merge (squash) January 16, 2024 15:27
@ankush ankush merged commit 642e9f4 into frappe:develop Jan 16, 2024
24 of 25 checks passed
@frappe frappe unlocked this conversation Jan 16, 2024
ankush added a commit that referenced this pull request Jan 17, 2024
ankush added a commit to ankush/frappe that referenced this pull request Jan 17, 2024
@ankush ankush mentioned this pull request Jan 17, 2024
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defer backport Backports for some PR are deferred for a week or two to test them properly before releasing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

search_link fails when txt contains parentheses
4 participants