[Fix] oauth url delimiter moved to function instead of global #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like a constant, does the delimiter change? |
|
Space is used as delimiter, I had to change it for one external app. That's why made a variable, so I don't have to type delimiter everywhere. After learning variables should not be kept global added this in function. |
rmehta
requested changes
Nov 12, 2016
| @@ -11,7 +11,8 @@ | |||
| from oauthlib.oauth2.rfc6749.endpoints.revocation import RevocationEndpoint | |||
| from oauthlib.common import Request | |||
|
|
|||
| separated_by = " " | |||
| def oauth_url_delimiter(separator_character=" "): | |||
| return separator_character | |||
There was a problem hiding this comment.
better choice for name would be get_url_delimiter since it is expected to return something.
rmehta
approved these changes
Nov 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rmehta
found another global and moved it in function.
will this work?